fase 6 - Controlled Rename Execute API (bevestigde rename op basis van preview) afgerond
This commit is contained in:
Executable
+216
@@ -0,0 +1,216 @@
|
||||
#!/usr/bin/env bash
|
||||
set -euo pipefail
|
||||
|
||||
if [ -z "${BASE_URL:-}" ]; then
|
||||
if curl --silent --fail http://127.0.0.1:8085/api/health >/dev/null 2>&1; then
|
||||
BASE_URL="http://127.0.0.1:8085"
|
||||
elif curl --silent --fail http://host.containers.internal:8085/api/health >/dev/null 2>&1; then
|
||||
BASE_URL="http://host.containers.internal:8085"
|
||||
else
|
||||
echo "ERROR: could not determine BASE_URL. Tried 127.0.0.1 and host.containers.internal." >&2
|
||||
exit 1
|
||||
fi
|
||||
fi
|
||||
|
||||
if [ -z "${TEST_MEDIA_ROOT:-}" ]; then
|
||||
for candidate in \
|
||||
"/Volumes/8TB/Shared_Folders/TV_Shows" \
|
||||
"/Volumes/8TB_RAID1/Shared_Folders/Library/TV_Shows"
|
||||
do
|
||||
if [ -d "$candidate" ] && [ -w "$candidate" ]; then
|
||||
TEST_MEDIA_ROOT="$candidate"
|
||||
break
|
||||
fi
|
||||
done
|
||||
fi
|
||||
|
||||
if [ -z "${TEST_MEDIA_ROOT:-}" ]; then
|
||||
echo "ERROR: no writable allowed media root found. Set TEST_MEDIA_ROOT." >&2
|
||||
exit 1
|
||||
fi
|
||||
|
||||
TEST_DIR="${TEST_MEDIA_ROOT}/_rename_mvp_phase6_$(date +%s)_$$"
|
||||
mkdir -p "${TEST_DIR}"
|
||||
|
||||
TMP_DIR="$(mktemp -d)"
|
||||
trap 'rm -rf "$TMP_DIR"' EXIT
|
||||
|
||||
SESSION_ID_1="rename-exec-ok-$(date +%s)-$$"
|
||||
SESSION_ID_2="rename-exec-no-confirm-$(date +%s)-$$"
|
||||
SESSION_ID_3="rename-exec-preflight-$(date +%s)-$$"
|
||||
|
||||
clear_session() {
|
||||
local sid="$1"
|
||||
curl --fail --silent --show-error -X DELETE \
|
||||
"${BASE_URL}/api/session/selected-episodes?session_id=${sid}" \
|
||||
>/dev/null
|
||||
curl --fail --silent --show-error -X DELETE \
|
||||
"${BASE_URL}/api/session/selected-files?session_id=${sid}" \
|
||||
>/dev/null
|
||||
}
|
||||
|
||||
add_payloads() {
|
||||
local sid="$1"
|
||||
local file1="$2"
|
||||
local file2="$3"
|
||||
|
||||
cat > "${TMP_DIR}/episodes_${sid}.json" <<'JSON'
|
||||
{
|
||||
"items": [
|
||||
{
|
||||
"id": 1,
|
||||
"series": "Elsbeth",
|
||||
"year": "2024",
|
||||
"season_number": 1,
|
||||
"episode_number": 1,
|
||||
"title": "Pilot"
|
||||
},
|
||||
{
|
||||
"id": 2,
|
||||
"series": "Elsbeth",
|
||||
"year": "2024",
|
||||
"season_number": 1,
|
||||
"episode_number": 2,
|
||||
"title": "Second Episode"
|
||||
}
|
||||
]
|
||||
}
|
||||
JSON
|
||||
|
||||
cat > "${TMP_DIR}/files_${sid}.json" <<JSON
|
||||
{
|
||||
"items": [
|
||||
{
|
||||
"path": "${file1}",
|
||||
"name": "$(basename "${file1}")"
|
||||
},
|
||||
{
|
||||
"path": "${file2}",
|
||||
"name": "$(basename "${file2}")"
|
||||
}
|
||||
]
|
||||
}
|
||||
JSON
|
||||
|
||||
curl --fail --silent --show-error \
|
||||
-X POST "${BASE_URL}/api/session/selected-episodes?session_id=${sid}" \
|
||||
-H "Content-Type: application/json" \
|
||||
--data @"${TMP_DIR}/episodes_${sid}.json" \
|
||||
>/dev/null
|
||||
|
||||
curl --fail --silent --show-error \
|
||||
-X POST "${BASE_URL}/api/session/selected-files?session_id=${sid}" \
|
||||
-H "Content-Type: application/json" \
|
||||
--data @"${TMP_DIR}/files_${sid}.json" \
|
||||
>/dev/null
|
||||
}
|
||||
|
||||
echo "== Feature test 1: confirmed execute performs renames =="
|
||||
SRC1="${TEST_DIR}/src1.mkv"
|
||||
SRC2="${TEST_DIR}/src2.mp4"
|
||||
printf "a" > "${SRC1}"
|
||||
printf "b" > "${SRC2}"
|
||||
|
||||
clear_session "${SESSION_ID_1}"
|
||||
add_payloads "${SESSION_ID_1}" "${SRC1}" "${SRC2}"
|
||||
|
||||
curl --fail --silent --show-error \
|
||||
-X POST "${BASE_URL}/api/session/rename-execute?session_id=${SESSION_ID_1}&confirm=true" \
|
||||
-o "${TMP_DIR}/rename_ok.json"
|
||||
|
||||
cat "${TMP_DIR}/rename_ok.json"
|
||||
|
||||
python3 - "${TMP_DIR}/rename_ok.json" <<'PY'
|
||||
import json
|
||||
import sys
|
||||
from pathlib import Path
|
||||
|
||||
data = json.loads(Path(sys.argv[1]).read_text(encoding="utf-8"))
|
||||
assert data.get("executed") is True, "execute should be true"
|
||||
assert data.get("preflight_ok") is True, "preflight should be true"
|
||||
assert len(data.get("items", [])) == 2, "expected 2 item results"
|
||||
assert all(item.get("status") == "renamed" for item in data["items"]), "all items should be renamed"
|
||||
print("confirmed rename validation passed")
|
||||
PY
|
||||
|
||||
DST1="${TEST_DIR}/Elsbeth (2024) - S01E01 - Pilot.mkv"
|
||||
DST2="${TEST_DIR}/Elsbeth (2024) - S01E02 - Second Episode.mp4"
|
||||
test ! -f "${SRC1}"
|
||||
test ! -f "${SRC2}"
|
||||
test -f "${DST1}"
|
||||
test -f "${DST2}"
|
||||
|
||||
echo
|
||||
echo "== Feature test 2: missing confirm fails safely without writes =="
|
||||
SRC3="${TEST_DIR}/src3.mkv"
|
||||
SRC4="${TEST_DIR}/src4.mp4"
|
||||
printf "c" > "${SRC3}"
|
||||
printf "d" > "${SRC4}"
|
||||
|
||||
clear_session "${SESSION_ID_2}"
|
||||
add_payloads "${SESSION_ID_2}" "${SRC3}" "${SRC4}"
|
||||
|
||||
curl --silent --show-error \
|
||||
-o "${TMP_DIR}/rename_no_confirm.json" \
|
||||
-w "%{http_code}" \
|
||||
-X POST "${BASE_URL}/api/session/rename-execute?session_id=${SESSION_ID_2}" \
|
||||
> "${TMP_DIR}/rename_no_confirm.status"
|
||||
|
||||
cat "${TMP_DIR}/rename_no_confirm.json"
|
||||
|
||||
python3 - "${TMP_DIR}/rename_no_confirm.status" "${TMP_DIR}/rename_no_confirm.json" <<'PY'
|
||||
import json
|
||||
import sys
|
||||
from pathlib import Path
|
||||
|
||||
status = Path(sys.argv[1]).read_text(encoding="utf-8").strip()
|
||||
data = json.loads(Path(sys.argv[2]).read_text(encoding="utf-8"))
|
||||
assert status == "400", f"expected HTTP 400, got {status}"
|
||||
assert "detail" in data, "error response missing detail"
|
||||
assert "confirm=true" in data["detail"], "detail should mention confirm=true requirement"
|
||||
print("missing confirm validation passed")
|
||||
PY
|
||||
|
||||
test -f "${SRC3}"
|
||||
test -f "${SRC4}"
|
||||
|
||||
echo
|
||||
echo "== Feature test 3: preflight failure blocks all writes =="
|
||||
SRC5="${TEST_DIR}/src5.mkv"
|
||||
SRC6="${TEST_DIR}/src6.mp4"
|
||||
printf "e" > "${SRC5}"
|
||||
printf "f" > "${SRC6}"
|
||||
|
||||
# Force destination conflict for first mapping.
|
||||
CONFLICT1="${TEST_DIR}/Elsbeth (2024) - S01E01 - Pilot.mkv"
|
||||
printf "existing" > "${CONFLICT1}"
|
||||
|
||||
clear_session "${SESSION_ID_3}"
|
||||
add_payloads "${SESSION_ID_3}" "${SRC5}" "${SRC6}"
|
||||
|
||||
curl --fail --silent --show-error \
|
||||
-X POST "${BASE_URL}/api/session/rename-execute?session_id=${SESSION_ID_3}&confirm=true" \
|
||||
-o "${TMP_DIR}/rename_preflight_fail.json"
|
||||
|
||||
cat "${TMP_DIR}/rename_preflight_fail.json"
|
||||
|
||||
python3 - "${TMP_DIR}/rename_preflight_fail.json" <<'PY'
|
||||
import json
|
||||
import sys
|
||||
from pathlib import Path
|
||||
|
||||
data = json.loads(Path(sys.argv[1]).read_text(encoding="utf-8"))
|
||||
assert data.get("executed") is False, "execute should be false on preflight failure"
|
||||
assert data.get("preflight_ok") is False, "preflight should be false"
|
||||
items = data.get("items", [])
|
||||
assert len(items) == 2, "expected 2 item statuses"
|
||||
assert any("destination file already exists" in " ".join(i.get("errors", [])) for i in items), \
|
||||
"expected destination conflict error"
|
||||
print("preflight failure validation passed")
|
||||
PY
|
||||
|
||||
test -f "${SRC5}"
|
||||
test -f "${SRC6}"
|
||||
|
||||
echo
|
||||
echo "All rename execute feature tests passed."
|
||||
Reference in New Issue
Block a user