feat: preffered startup paths

webui/backend/tests/golden/test_api_settings_golden.py

@@ -13,14 +13,22 @@ sys.path.insert(0, str(Path(__file__).resolve().parents[3]))
 from backend.app.dependencies import get_settings_service
 from backend.app.db.settings_repository import SettingsRepository
 from backend.app.main import app
+from backend.app.security.path_guard import PathGuard
 from backend.app.services.settings_service import SettingsService
 
 
 class SettingsApiGoldenTest(unittest.TestCase):
     def setUp(self) -> None:
         self.temp_dir = tempfile.TemporaryDirectory()
-        repository = SettingsRepository(str(Path(self.temp_dir.name) / "tasks.db"))
-        service = SettingsService(repository=repository)
+        self.root_path = Path(self.temp_dir.name) / "storage1"
+        self.root_path.mkdir()
+        (self.root_path / "docs").mkdir()
+        (self.root_path / "file.txt").write_text("sample", encoding="utf-8")
+        repository = SettingsRepository(str(Path(self.temp_dir.name) / "settings.db"))
+        service = SettingsService(
+            repository=repository,
+            path_guard=PathGuard({"storage1": str(self.root_path)}),
+        )
 
         async def _override_settings_service() -> SettingsService:
             return service
@@ -45,14 +53,118 @@ class SettingsApiGoldenTest(unittest.TestCase):
         response = self._request("GET", "/api/settings")
 
         self.assertEqual(response.status_code, 200)
-        self.assertEqual(response.json(), {"show_thumbnails": False})
+        self.assertEqual(
+            response.json(),
+            {
+                "show_thumbnails": False,
+                "preferred_startup_path_left": None,
+                "preferred_startup_path_right": None,
+            },
+        )
 
-    def test_settings_update_persistence(self) -> None:
-        response = self._request("POST", "/api/settings", {"show_thumbnails": True})
+    def test_settings_legacy_single_path_is_used_only_for_left_fallback(self) -> None:
+        repository = SettingsRepository(str(Path(self.temp_dir.name) / "settings.db"))
+        repository.set_setting("preferred_startup_path", "storage1/docs")
+
+        response = self._request("GET", "/api/settings")
 
         self.assertEqual(response.status_code, 200)
-        self.assertEqual(response.json(), {"show_thumbnails": True})
-        self.assertEqual(self._request("GET", "/api/settings").json(), {"show_thumbnails": True})
+        self.assertEqual(
+            response.json(),
+            {
+                "show_thumbnails": False,
+                "preferred_startup_path_left": "storage1/docs",
+                "preferred_startup_path_right": None,
+            },
+        )
+
+    def test_settings_update_persistence_left_and_right(self) -> None:
+        response = self._request(
+            "POST",
+            "/api/settings",
+            {
+                "show_thumbnails": True,
+                "preferred_startup_path_left": "storage1/docs",
+                "preferred_startup_path_right": "storage1/docs",
+            },
+        )
+
+        self.assertEqual(response.status_code, 200)
+        self.assertEqual(
+            response.json(),
+            {
+                "show_thumbnails": True,
+                "preferred_startup_path_left": "storage1/docs",
+                "preferred_startup_path_right": "storage1/docs",
+            },
+        )
+        self.assertEqual(
+            self._request("GET", "/api/settings").json(),
+            {
+                "show_thumbnails": True,
+                "preferred_startup_path_left": "storage1/docs",
+                "preferred_startup_path_right": "storage1/docs",
+            },
+        )
+
+    def test_settings_preferred_startup_path_left_persistence(self) -> None:
+        response = self._request("POST", "/api/settings", {"preferred_startup_path_left": "storage1/docs"})
+
+        self.assertEqual(response.status_code, 200)
+        self.assertEqual(response.json()["preferred_startup_path_left"], "storage1/docs")
+        self.assertEqual(response.json()["preferred_startup_path_right"], None)
+
+    def test_settings_preferred_startup_path_right_persistence(self) -> None:
+        response = self._request("POST", "/api/settings", {"preferred_startup_path_right": "storage1/docs"})
+
+        self.assertEqual(response.status_code, 200)
+        self.assertEqual(response.json()["preferred_startup_path_left"], None)
+        self.assertEqual(response.json()["preferred_startup_path_right"], "storage1/docs")
+
+    def test_settings_preferred_startup_path_empty_string_resets_only_left_to_null(self) -> None:
+        self._request(
+            "POST",
+            "/api/settings",
+            {
+                "preferred_startup_path_left": "storage1/docs",
+                "preferred_startup_path_right": "storage1/docs",
+            },
+        )
+        response = self._request("POST", "/api/settings", {"preferred_startup_path_left": "   "})
+
+        self.assertEqual(response.status_code, 200)
+        self.assertEqual(response.json()["preferred_startup_path_left"], None)
+        self.assertEqual(response.json()["preferred_startup_path_right"], "storage1/docs")
+
+    def test_settings_preferred_startup_path_left_rejects_file_path(self) -> None:
+        response = self._request("POST", "/api/settings", {"preferred_startup_path_left": "storage1/file.txt"})
+
+        self.assertEqual(response.status_code, 409)
+        self.assertEqual(response.json()["error"]["code"], "path_type_conflict")
+
+    def test_settings_preferred_startup_path_right_rejects_file_path(self) -> None:
+        response = self._request("POST", "/api/settings", {"preferred_startup_path_right": "storage1/file.txt"})
+
+        self.assertEqual(response.status_code, 409)
+        self.assertEqual(response.json()["error"]["code"], "path_type_conflict")
+
+    def test_settings_preferred_startup_path_left_rejects_traversal(self) -> None:
+        response = self._request("POST", "/api/settings", {"preferred_startup_path_left": "storage1/../etc"})
+
+        self.assertEqual(response.status_code, 403)
+        self.assertEqual(response.json()["error"]["code"], "path_traversal_detected")
+
+    def test_settings_preferred_startup_path_right_rejects_invalid_root_alias(self) -> None:
+        response = self._request("POST", "/api/settings", {"preferred_startup_path_right": "unknown/docs"})
+
+        self.assertEqual(response.status_code, 403)
+        self.assertEqual(response.json()["error"]["code"], "invalid_root_alias")
+
+    def test_settings_preferred_startup_path_left_rejects_missing_directory(self) -> None:
+        response = self._request("POST", "/api/settings", {"preferred_startup_path_left": "storage1/missing"})
+
+        self.assertEqual(response.status_code, 404)
+        self.assertEqual(response.json()["error"]["code"], "path_not_found")
 
 
 if __name__ == "__main__":

webui/backend/tests/golden/test_ui_smoke_golden.py

@@ -65,6 +65,11 @@ class UiSmokeGoldenTest(unittest.TestCase):
         self.assertIn('id="settings-logs-tab"', body)
         self.assertIn('id="settings-show-thumbnails"', body)
         self.assertIn("Show thumbnails", body)
+        self.assertIn('id="settings-startup-path-left"', body)
+        self.assertIn('id="settings-startup-path-right"', body)
+        self.assertIn("Preferred startup path (left)", body)
+        self.assertIn("Preferred startup path (right)", body)
+        self.assertIn('id="settings-general-save-btn"', body)
         self.assertIn('id="settings-logs-list"', body)
         self.assertIn('id="viewer-content"', body)
         self.assertIn('id="editor-modal"', body)
@@ -118,6 +123,13 @@ class UiSmokeGoldenTest(unittest.TestCase):
         self.assertIn('async function loadSettings()', app_js)
         self.assertIn('await loadSettings();', app_js)
         self.assertIn('settings.showThumbnailsInput.onchange = handleShowThumbnailsChange;', app_js)
+        self.assertIn('settings.generalSaveButton.onclick = handlePreferredStartupPathSave;', app_js)
+        self.assertIn('preferredStartupPathLeft', app_js)
+        self.assertIn('preferredStartupPathRight', app_js)
+        self.assertIn('preferred_startup_path_left', app_js)
+        self.assertIn('preferred_startup_path_right', app_js)
+        self.assertIn('paneState("left").currentPath = settingsState.preferredStartupPathLeft || "/Volumes";', app_js)
+        self.assertIn('paneState("right").currentPath = settingsState.preferredStartupPathRight || "/Volumes";', app_js)
         self.assertIn('"/api/settings"', app_js)
         self.assertIn('`/api/files/thumbnail?', app_js)
         self.assertIn('function createMediaSlot(entry)', app_js)